[ET-VK][ez] Enable max_pool2d.default #13879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max_pool2d_with_indices is already implemented; this diff enables max_pool2d as well by just re-using the same implementation. Differential Revision: [D81513446](https://our.internmc.facebook.com/intern/diff/D81513446/) [ghstack-poisoned]
This was referenced Sep 2, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13879
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 1081075 with merge base 1a7441f ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
SS-JIA
pushed a commit
that referenced
this pull request
Sep 2, 2025
max_pool2d_with_indices is already implemented; this diff enables max_pool2d as well by just re-using the same implementation. Differential Revision: [D81513446](https://our.internmc.facebook.com/intern/diff/D81513446/) ghstack-source-id: 307028612 Pull Request resolved: #13879
This PR needs a
|
|
This pull request was exported from Phabricator. Differential Revision: D81513446 |
max_pool2d_with_indices is already implemented; this diff enables max_pool2d as well by just re-using the same implementation. Differential Revision: [D81513446](https://our.internmc.facebook.com/intern/diff/D81513446/) [ghstack-poisoned]
SS-JIA
pushed a commit
that referenced
this pull request
Sep 4, 2025
Pull Request resolved: #13879 max_pool2d_with_indices is already implemented; this diff enables max_pool2d as well by just re-using the same implementation. Differential Revision: [D81513446](https://our.internmc.facebook.com/intern/diff/D81513446/) ghstack-source-id: 307497053
|
This pull request was exported from Phabricator. Differential Revision: D81513446 |
max_pool2d_with_indices is already implemented; this diff enables max_pool2d as well by just re-using the same implementation. Differential Revision: [D81513446](https://our.internmc.facebook.com/intern/diff/D81513446/) [ghstack-poisoned]
SS-JIA
pushed a commit
that referenced
this pull request
Sep 4, 2025
Pull Request resolved: #13879 max_pool2d_with_indices is already implemented; this diff enables max_pool2d as well by just re-using the same implementation. ghstack-source-id: 307537769 Differential Revision: [D81513446](https://our.internmc.facebook.com/intern/diff/D81513446/)
|
This pull request was exported from Phabricator. Differential Revision: D81513446 |
max_pool2d_with_indices is already implemented; this diff enables max_pool2d as well by just re-using the same implementation. Differential Revision: [D81513446](https://our.internmc.facebook.com/intern/diff/D81513446/) [ghstack-poisoned]
This was referenced Sep 5, 2025
|
This pull request was exported from Phabricator. Differential Revision: D81513446 |
manuelcandales
approved these changes
Sep 5, 2025
max_pool2d_with_indices is already implemented; this diff enables max_pool2d as well by just re-using the same implementation. Differential Revision: [D81513446](https://our.internmc.facebook.com/intern/diff/D81513446/) [ghstack-poisoned]
max_pool2d_with_indices is already implemented; this diff enables max_pool2d as well by just re-using the same implementation. Differential Revision: [D81513446](https://our.internmc.facebook.com/intern/diff/D81513446/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D81513446 |
facebook-github-bot
merged commit fd5798c
into
gh/SS-JIA/319/base
116 of 118 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
SS-JIA
pushed a commit
that referenced
this pull request
Sep 8, 2025
Pull Request resolved: #13879 max_pool2d_with_indices is already implemented; this diff enables max_pool2d as well by just re-using the same implementation. ghstack-source-id: 308092876 Differential Revision: [D81513446](https://our.internmc.facebook.com/intern/diff/D81513446/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
max_pool2d_with_indices is already implemented; this diff enables max_pool2d as well by just re-using the same implementation.
Differential Revision: D81513446